Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce utf8 test sensibility #8393

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@guillep2k
Copy link
Member

commented Oct 6, 2019

I keep cutting down the utf8 tests. This time to fix this error:

image

As always, errors occur only from time to time.

@guillep2k

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

Connected with this fail: #8349 (comment)

@lafriks
lafriks approved these changes Oct 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 6, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 6, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 6, 2019

Codecov Report

Merging #8393 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8393      +/-   ##
=========================================
+ Coverage   41.79%   41.8%   +0.01%     
=========================================
  Files         497     497              
  Lines       65608   65608              
=========================================
+ Hits        27419   27429      +10     
+ Misses      34673   34665       -8     
+ Partials     3516    3514       -2
Impacted Files Coverage Δ
models/repo_indexer.go 70.15% <0%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08896cd...097836f. Read the comment docs.

@techknowlogick techknowlogick merged commit 356e1a7 into go-gitea:master Oct 7, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.