Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues/pr list broken when there are many repositories #8409

Merged
merged 7 commits into from Oct 8, 2019

Conversation

@lunny
Copy link
Member

commented Oct 7, 2019

Fix #7750

This PR adds a new repositories sub query as condition instead of list all repository ids.

@lunny lunny added this to the 1.10.0 milestone Oct 7, 2019
routers/user/home.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 label Oct 7, 2019
lunny added 3 commits Oct 7, 2019
@lunny lunny force-pushed the lunny:lunny/fix_issues_bug branch from 388143e to 209f76e Oct 7, 2019
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 7, 2019
@guillep2k

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Sorry, I've missed that when reviewing.

lunny added 2 commits Oct 7, 2019
models/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 8, 2019
@6543
6543 approved these changes Oct 8, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #8409 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8409      +/-   ##
==========================================
+ Coverage   41.81%   41.81%   +<.01%     
==========================================
  Files         497      497              
  Lines       65611    65571      -40     
==========================================
- Hits        27432    27417      -15     
+ Misses      34664    34642      -22     
+ Partials     3515     3512       -3
Impacted Files Coverage Δ
models/issue.go 51% <100%> (+0.29%) ⬆️
models/user.go 48.82% <28.57%> (-1.36%) ⬇️
routers/user/home.go 56.65% <46.66%> (+3.49%) ⬆️
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 72.19% <0%> (-0.98%) ⬇️
models/repo_indexer.go 70.15% <0%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a269f7...22f60fc. Read the comment docs.

@lunny lunny merged commit 78438d3 into go-gitea:master Oct 8, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 8, 2019
…8409)

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests
lafriks added a commit that referenced this pull request Oct 8, 2019
…#8409) (#8418)

* Fix issues/pr list broken when there are many repositories (#8409)

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests

* rm unused import
lafriks added a commit that referenced this pull request Oct 8, 2019
…sitories (#8409) (#8418)"

This reverts commit 0ea4b78.
@lunny lunny deleted the lunny:lunny/fix_issues_bug branch Oct 8, 2019
lunny added a commit that referenced this pull request Oct 8, 2019
lafriks added a commit that referenced this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.