Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix issues/pr list broken when there are many repositories (#8409) #8418

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@6543
Copy link
Member

commented Oct 8, 2019

Backport of #8409

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests
@lunny lunny added this to the 1.9.4 milestone Oct 8, 2019
@lunny lunny added the kind/bug label Oct 8, 2019
@guillep2k

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@lunny the version of xorm is OK for this?

@GiteaBot GiteaBot added the lgtm/need 2 label Oct 8, 2019
@6543

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

routers/user/home.go:20:2: imported and not used: "github.com/Unknwon/com"
make: *** [Makefile:311: gitea] Fehler 2

@lunny

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@guillep2k Only SetExpr with Where is a new feature of recent xorm but this PR has no that usecase. release/v1.9 use builder v0.3.5 which supports In with subquery, https://gitea.com/xorm/builder/src/tag/v0.3.5/cond_in.go#L189 .
But I will wait until a new try instance upgrade before merge this.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 8, 2019
@6543 6543 referenced this pull request Oct 8, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 8, 2019
@lunny lunny added the status/blocked label Oct 8, 2019
@lafriks lafriks merged commit 0ea4b78 into go-gitea:release/v1.9 Oct 8, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
lafriks added a commit that referenced this pull request Oct 8, 2019
…sitories (#8409) (#8418)"

This reverts commit 0ea4b78.
@lafriks

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

sh*#, did not see blocked label :/

@6543 6543 deleted the 6543-forks:backports_8409 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.