Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Close() method to gogitRepository (#8901) #8958

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@zeripath
Copy link
Contributor

zeripath commented Nov 13, 2019

Backport #8901 - Adjusted slightly for 1.9

In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.

This PR adds this Close function and adds the Close functions as necessary.

In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.

Fixes #7947

@zeripath zeripath added the kind/bug label Nov 13, 2019
@zeripath zeripath added this to the 1.9.6 milestone Nov 13, 2019
In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.

This PR adds this Close function and adds the Close functions as necessary.

In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.

Fixes #7947
@zeripath zeripath force-pushed the zeripath:backport-8901-1.9 branch from 21a1897 to fe3f287 Nov 13, 2019
@6543
6543 approved these changes Nov 13, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Nov 13, 2019
@zeripath zeripath merged commit fb5af37 into go-gitea:release/v1.9 Nov 13, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath zeripath deleted the zeripath:backport-8901-1.9 branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.