Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] add comments endpoint for single comment #9494

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@6543
Copy link
Member

6543 commented Dec 25, 2019

close #9486
usefull at #4811 (#9488)

add GET /repos/{owner}/{repo}/issues/comments/{id}

GitHub reference spec: link

@6543 6543 mentioned this pull request Dec 25, 2019
12 of 12 tasks complete
@6543 6543 force-pushed the 6543-forks:api-comments-get-single branch from a6ad741 to 1bfe4ed Dec 25, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5749b26). Click here to learn what that means.
The diff coverage is 72.46%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #9494   +/-   ##
========================================
  Coverage          ?   42.2%           
========================================
  Files             ?     578           
  Lines             ?   76138           
  Branches          ?       0           
========================================
  Hits              ?   32135           
  Misses            ?   40019           
  Partials          ?    3984
Impacted Files Coverage Δ
routers/api/v1/api.go 73.96% <100%> (ø)
routers/api/v1/repo/issue_comment.go 56.22% <70.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5749b26...ed287f6. Read the comment docs.

models/issue_comment.go Outdated Show resolved Hide resolved
@6543

This comment has been minimized.

Copy link
Member Author

6543 commented Dec 25, 2019

@zeripath I thought comment.APIURL() is a genaral function wich #9488 will use - but i dont know when this get ready ... so I thought add this smal func to this one ... but yes its unrelated - removed

@6543 6543 requested a review from zeripath Dec 25, 2019
6543 added a commit to 6543-forks/gitea that referenced this pull request Dec 25, 2019
@lunny lunny added the kind/api label Dec 26, 2019
@lunny lunny added this to the 1.12.0 milestone Dec 26, 2019
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 2, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 2, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 2, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 3, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 3, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 3, 2020
@6543 6543 force-pushed the 6543-forks:api-comments-get-single branch 2 times, most recently from 05cb801 to ee6da6e Jan 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 7, 2020
@6543 6543 mentioned this pull request Jan 7, 2020
0 of 7 tasks complete
6543 added 2 commits Dec 25, 2019
 and complete error list for swagger in other func
@6543 6543 force-pushed the 6543-forks:api-comments-get-single branch from 6e7d525 to 901cca5 Jan 8, 2020
@6543

This comment has been minimized.

Copy link
Member Author

6543 commented Jan 8, 2020

@GiteaBot GiteaBot removed the lgtm/need 1 label Jan 8, 2020
@GiteaBot GiteaBot added the lgtm/done label Jan 8, 2020
@6543

This comment has been minimized.

Copy link
Member Author

6543 commented Jan 8, 2020

ready for merge 🚀

@lunny lunny merged commit e88d67b into go-gitea:master Jan 8, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@6543 6543 deleted the 6543-forks:api-comments-get-single branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.