Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blue box-shadow to blue buttons in normal theme #9573

Merged
merged 2 commits into from Jan 1, 2020

Conversation

@jolheiser
Copy link
Member

jolheiser commented Jan 1, 2020

Fix #9407

It was mentioned in the issue to use border instead of box-shadow, however semantic (fomantic) used box-shadow so I went with that. arc-green also uses box-shadow.
This CSS more or less copies arc-green but with blue rather than green.
The shade of blue matches the hover color, which is how it used to look afaik (or at the very least is how arc-green operates)

Screenshot from 2019-12-31 21-01-59

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #9573 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9573      +/-   ##
==========================================
+ Coverage   41.98%   41.98%   +<.01%     
==========================================
  Files         577      577              
  Lines       75970    75970              
==========================================
+ Hits        31893    31898       +5     
+ Misses      40132    40124       -8     
- Partials     3945     3948       +3
Impacted Files Coverage Δ
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️
models/webhook.go 70.46% <0%> (+1.06%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8941f7f...8fa9c3e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Jan 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 1, 2020
@lunny lunny added the kind/bug label Jan 1, 2020
@lunny lunny added this to the 1.11.0 milestone Jan 1, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 1, 2020
@jolheiser

This comment has been minimized.

Copy link
Member Author

jolheiser commented Jan 1, 2020

Ping LGTM (does it even respond to me?)

EDIT: Yes it does. 🔥

@techknowlogick techknowlogick merged commit a864d61 into go-gitea:master Jan 1, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@jolheiser jolheiser deleted the jolheiser:fix_9407_2 branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.