Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top author stats to activity page #9615

Open
wants to merge 8 commits into
base: master
from

Conversation

@lafriks
Copy link
Member

lafriks commented Jan 5, 2020

Displays top ten authors from git history in specified period of time ordered in from most commits to least

image

image

@lafriks lafriks force-pushed the lafriks-fork:feat/author_top branch from 8376af0 to 98f01ad Jan 6, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 6, 2020
models/repo_activity.go Outdated Show resolved Hide resolved
templates/repo/activity.tmpl Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 label Jan 6, 2020
@6543

This comment has been minimized.

Copy link
Member

6543 commented Jan 6, 2020

I have no Idear why but the time-periode-drop-down-menue dont work on chrome anymore with this PR :(

EDIT: Firefox also affected

Copy link
Member

guillep2k left a comment

LGTM. The time-period-drop-down-menu mentioned by @6543 is worth a look; perhaps one of the updated libraries affected that, or the problem is in master already and not related to this PR.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 7, 2020
package.json Show resolved Hide resolved
@6543
6543 approved these changes Jan 9, 2020
Copy link
Member

6543 left a comment

lgtm beside time-period-drop-down-menu

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 9, 2020
@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 9, 2020

As what @6543 said, time-period-drop-down-menu is broken.

Copy link
Member

techknowlogick left a comment

blocking per @lunny comment

@6543

This comment has been minimized.

Copy link
Member

6543 commented Jan 14, 2020

any progress why this time-period-drop-down-menu thinkg is broken?

@lafriks lafriks force-pushed the lafriks-fork:feat/author_top branch from 98f01ad to 2bdef3e Jan 15, 2020
@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Jan 15, 2020

@techknowlogick @6543 somehow dropdown stops to work if placed inside Vue app, so I moved move app to smaller scope, works now

@lafriks lafriks force-pushed the lafriks-fork:feat/author_top branch from 2bdef3e to 2c5d728 Jan 15, 2020
@6543
6543 approved these changes Jan 15, 2020
@zeripath zeripath changed the title Add top author stats to acitivity page Add top author stats to activity page Jan 15, 2020
@sapk
sapk approved these changes Jan 16, 2020
@@ -6,6 +6,8 @@ import './publicPath.js';
import './gitGraphLoader.js';
import './semanticDropdown.js';

import ActivityTopAuthors from './components/ActivityTopAuthors.vue';

This comment has been minimized.

Copy link
@sapk

sapk Jan 16, 2020

Member

Outside this PR, we should maybe start doing code-splitting and lazy load components that are not always displayed/used now that we "build" all the frontend.

lafriks and others added 4 commits Jan 16, 2020
@sapk

This comment has been minimized.

Copy link
Member

sapk commented Jan 16, 2020

Does @lunny and @techknowlogick concerns are solved ?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #9615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9615   +/-   ##
=======================================
  Coverage   42.22%   42.22%           
=======================================
  Files         603      603           
  Lines       78899    78899           
=======================================
  Hits        33318    33318           
  Misses      41493    41493           
  Partials     4088     4088

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a2134c...6e5bd93. Read the comment docs.

@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Jan 16, 2020

@techknowlogick need your review

@sapk

This comment has been minimized.

Copy link
Member

sapk commented Jan 16, 2020

@lafriks some stats seems to have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.