Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update js dependencies #9676

Merged
merged 4 commits into from Jan 10, 2020
Merged

update js dependencies #9676

merged 4 commits into from Jan 10, 2020

Conversation

@silverwind
Copy link
Member

silverwind commented Jan 9, 2020

Result of make npm-update. The only notable change is postcss-cli dropping support for node 6 and 8 but it does not affect us because we already require 10.

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 label Jan 9, 2020
@6543
6543 approved these changes Jan 9, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 9, 2020
@sapk
sapk approved these changes Jan 9, 2020
sapk and others added 2 commits Jan 9, 2020
"@babel/preset-env": "7.7.4",
"@babel/runtime": "7.7.4",
"@babel/core": "7.7.7",
"@babel/plugin-transform-runtime": "7.7.6",

This comment has been minimized.

Copy link
@bagasme

bagasme Jan 10, 2020

Contributor

Why update this one version behind?

This comment has been minimized.

Copy link
@silverwind

silverwind Jan 10, 2020

Author Member

No idea, it's the latest published version.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #9676 into master will decrease coverage by 0.01%.
The diff coverage is 57.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9676      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.02%     
==========================================
  Files         587      589       +2     
  Lines       77991    77989       -2     
==========================================
- Hits        32955    32945      -10     
- Misses      40995    41003       +8     
  Partials     4041     4041
Impacted Files Coverage Δ
models/pull.go 41.37% <ø> (-4.41%) ⬇️
models/action.go 46.87% <ø> (-11.09%) ⬇️
modules/repository/repo.go 26.28% <0%> (-7.27%) ⬇️
modules/templates/helper.go 40.24% <0%> (ø) ⬆️
services/pull/check.go 50.67% <0%> (-6.18%) ⬇️
models/update.go 6.38% <0%> (-6.32%) ⬇️
services/mirror/mirror.go 18.75% <0%> (ø) ⬆️
modules/notification/action/action.go 35.65% <0%> (ø) ⬆️
modules/notification/indexer/indexer.go 50.72% <100%> (ø) ⬆️
modules/repofiles/action.go 63.63% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc75ab7...98e8443. Read the comment docs.

@sapk sapk merged commit 3143bb1 into go-gitea:master Jan 10, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@silverwind silverwind deleted the silverwind:npm-update branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.