Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds wrapper for blob content #158
referenced this pull request
Apr 4, 2019
zeripath left a comment
Hmm. You're probably gonna hate me but I don't think we need this after all.
It doesn't really fix the issue with blobs being very large as marshalJson will still put the whole thing in memory.
There's no requirement for us to ever actually completely instantiate a BlobResponse on server we just need to emit it.
So we don't need to do this wrapper. (At least not on the server - we should just change the server to emit the JSON - although I'll comment on the pr about this.) At client level later on we might also want to do some clever stuff but this API should still be correct.