Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to sha1 as key #169

Merged
merged 1 commit into from May 10, 2019

Conversation

4 participants
@techknowlogick
Copy link
Member

commented May 9, 2019

@zeripath

This comment has been minimized.

Copy link

commented May 9, 2019

Is it worth leaving the hashed token in?

@GiteaBot GiteaBot added the lgtm/need 2 label May 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 9, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

I never ended up sending the hashed token in API response. So I took this part out of struct to reduce any confusion.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 10, 2019

@lafriks lafriks merged commit 9251bef into master May 10, 2019

3 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details

@lafriks lafriks deleted the techknowlogick-patch-1 branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.