New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL 4.6 support #88

Closed
kjozic opened this Issue Oct 8, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@kjozic

kjozic commented Oct 8, 2017

When can we expect support for OpenGL 4.6?

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Oct 8, 2017

Member

It should be straightforward to generate the new bindings. I'll try and make time this week to do it.

Member

errcw commented Oct 8, 2017

It should be straightforward to generate the new bindings. I'll try and make time this week to do it.

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Oct 8, 2017

Member

It should be straightforward to generate the new bindings. I'll try and make time this week to do it.

Member

errcw commented Oct 8, 2017

It should be straightforward to generate the new bindings. I'll try and make time this week to do it.

@kjozic

This comment has been minimized.

Show comment
Hide comment
@kjozic

kjozic Nov 5, 2017

When I try to generate the new bindings using glow (glow generate -out=./v4.6-core/gl/ -api=gl -version=4.6 -profile=core -xml=../glow/xml/) following error occurs:
2017/11/05 12:32:03 unable to generate package: &{gl 4.6 core /home/kreso/golang/src/github.com/go-gl/glow/tmpl <nil> <nil> false}

kjozic commented Nov 5, 2017

When I try to generate the new bindings using glow (glow generate -out=./v4.6-core/gl/ -api=gl -version=4.6 -profile=core -xml=../glow/xml/) following error occurs:
2017/11/05 12:32:03 unable to generate package: &{gl 4.6 core /home/kreso/golang/src/github.com/go-gl/glow/tmpl <nil> <nil> false}

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 7, 2017

Member

That error happens on this line:

https://github.com/go-gl/glow/blob/75d9c6716e5939e941a3fc5e2d6afaf36f52514d/main.go#L123

If it happens, that means spec.HasPackage(packageSpec) was not true for any of the specs in the XML directory.

Member

dmitshur commented Nov 7, 2017

That error happens on this line:

https://github.com/go-gl/glow/blob/75d9c6716e5939e941a3fc5e2d6afaf36f52514d/main.go#L123

If it happens, that means spec.HasPackage(packageSpec) was not true for any of the specs in the XML directory.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 7, 2017

Member

It looks like we need to update the contents of the XML directory with the latest XML specifications. The ones currently there now only have 4.5, not 4.6.

@errcw Is it documented anywhere how to update the contents of the XML directory? I can't find it (not in the README of the repo, nor in the README within the xml directory, nor in wiki).

Edit: I found there's a glow download command for it.

Member

dmitshur commented Nov 7, 2017

It looks like we need to update the contents of the XML directory with the latest XML specifications. The ones currently there now only have 4.5, not 4.6.

@errcw Is it documented anywhere how to update the contents of the XML directory? I can't find it (not in the README of the repo, nor in the README within the xml directory, nor in wiki).

Edit: I found there's a glow download command for it.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 10, 2017

Member

We need to decide to how to proceed in go-gl/glow#90 to make progress on this issue.

Member

dmitshur commented Nov 10, 2017

We need to decide to how to proceed in go-gl/glow#90 to make progress on this issue.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 4, 2018

Member

Now that go-gl/glow#90 is resolved, we can proceed here.

Member

dmitshur commented Mar 4, 2018

Now that go-gl/glow#90 is resolved, we can proceed here.

@dmitshur dmitshur self-assigned this Mar 4, 2018

dmitshur added a commit that referenced this issue Mar 4, 2018

Add v4.6-{core,compatibility}/gl prebuilt packages for OpenGL 4.6.
Update README to mention newly available prebuilt packages.

Helps #88.

dmitshur added a commit that referenced this issue Mar 4, 2018

v4.6-core, v4.6-compatibility: Generate initial packages.
Done with latest version of glow, after downloading latest XML files:

	cd glow
	glow generate
	cd ../gl
	glow generate -out=./v4.6-core/gl/ -api=gl -version=4.6 -profile=core -xml=../glow/xml/
	glow generate -out=./v4.6-compatibility/gl/ -api=gl -version=4.6 -profile=compatibility -xml=../glow/xml/

Resolves #88.
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 4, 2018

Member

I've created PR #92 that'll resolve this issue (it's an updated version of #90).

Member

dmitshur commented Mar 4, 2018

I've created PR #92 that'll resolve this issue (it's an updated version of #90).

@errcw errcw closed this in #92 Mar 4, 2018

errcw added a commit that referenced this issue Mar 4, 2018

Add v4.6-{core,compatibility}/gl prebuilt packages for OpenGL 4.6. (#92)
* Add v4.6-{core,compatibility}/gl prebuilt packages for OpenGL 4.6.

Update README to mention newly available prebuilt packages.

Helps #88.

* v4.6-core, v4.6-compatibility: Generate initial packages.

Done with latest version of glow, after downloading latest XML files:

	cd glow
	glow generate
	cd ../gl
	glow generate -out=./v4.6-core/gl/ -api=gl -version=4.6 -profile=core -xml=../glow/xml/
	glow generate -out=./v4.6-compatibility/gl/ -api=gl -version=4.6 -profile=compatibility -xml=../glow/xml/

Resolves #88.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment