Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2/glfw: MouseButtonCallback parameter mod should be renamed to mods #245

Open
dmitshur opened this Issue Apr 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

dmitshur commented Apr 8, 2019

This is a very minor issue. Filing so I don't forget.

https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#MouseButtonCallback

The parameter mod should be mods, for consistency with other callbacks and the upstream GLFW (the C library) API.

@tapir

This comment has been minimized.

Copy link
Member

tapir commented Apr 8, 2019

Good catch. If I recall correctly there should be more things like this because in the very beginning I didn't care much about parameter names.

Also it would be nice if at some point we could switch to named return values when there is multiple things to return, just for better self documentation. In most of the cases it could save you a round-trip to the documentation page.

@tapir tapir added the glfw-3.3 label Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.