New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve template files relative to $GOPATH; Fixes go-gl/glow#35 #36

Merged
merged 2 commits into from Aug 15, 2014

Conversation

Projects
None yet
2 participants
@slimsag
Member

slimsag commented Aug 15, 2014

This would resolve template files relative to $GOPATH (fixing issue #35).

@errcw

View changes

Show outdated Hide outdated package.go Outdated
var absPkgDir string
// pkgPath resolves a path relative to the package directory (see above).
func pkgPath(relPath string) string {

This comment has been minimized.

@errcw

errcw Aug 15, 2014

Member

push this function to the bottom (below the public API)

@errcw

errcw Aug 15, 2014

Member

push this function to the bottom (below the public API)

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Aug 15, 2014

Member

Thanks! Just a few minor comments.

Member

errcw commented Aug 15, 2014

Thanks! Just a few minor comments.

@slimsag

This comment has been minimized.

Show comment
Hide comment
@slimsag

slimsag Aug 15, 2014

Member

PTAL

Member

slimsag commented Aug 15, 2014

PTAL

errcw added a commit that referenced this pull request Aug 15, 2014

Merge pull request #36 from slimsag/abs_tmpl
Resolve template files relative to $GOPATH.

Fix #35.

@errcw errcw merged commit af29c66 into go-gl:master Aug 15, 2014

@slimsag slimsag deleted the slimsag:abs_tmpl branch Aug 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment