New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -restrict option; restrict symbol generation to JSON file #43

Merged
merged 4 commits into from Aug 18, 2014

Conversation

Projects
None yet
2 participants
@slimsag
Member

slimsag commented Aug 16, 2014

Fixes #42

@@ -61,5 +61,6 @@ A few notes about the flags to `generate`:
- `version`: The API version to generate. The `all` pseudo-version includes all functions and enumerations for the specified API.
- `profile`: For `gl` packages with version 3.2 or higher, `core` or `compatibility` ([explanation](http://www.opengl.org/wiki/Core_And_Compatibility_in_Contexts)).
- `addext`: A regular expression describing which extensions to include. `.*` by default, including everything.
- `restrict`: A JSON file that explicitly lists what enumerations / functions that Glow should generate (see example.json).

This comment has been minimized.

@errcw

errcw Aug 16, 2014

Member

I think this control obsoletes the addext and remext flags. Perhaps we could consider pulling out the functionality in this change? Otherwise we can take a separate clean-up pass.

@errcw

errcw Aug 16, 2014

Member

I think this control obsoletes the addext and remext flags. Perhaps we could consider pulling out the functionality in this change? Otherwise we can take a separate clean-up pass.

This comment has been minimized.

@slimsag

slimsag Aug 17, 2014

Member

I'm not so certain. Other people may be using addext/remext today and want it to keep working. Also it allows for a regular expression which could be more useful in certain situations -- don't think these options overlap each-other but instead compliment one another.

If you want, I can remove them though.

@slimsag

slimsag Aug 17, 2014

Member

I'm not so certain. Other people may be using addext/remext today and want it to keep working. Also it allows for a regular expression which could be more useful in certain situations -- don't think these options overlap each-other but instead compliment one another.

If you want, I can remove them though.

This comment has been minimized.

@errcw

errcw Aug 17, 2014

Member

Let's keep the parameters for now. Over the long term perhaps the right answer is to allow the JSON file to specify direct and regex inclusion parameters. Until then I agree we should keep a consistent API.

@errcw

errcw Aug 17, 2014

Member

Let's keep the parameters for now. Over the long term perhaps the right answer is to allow the JSON file to specify direct and regex inclusion parameters. Until then I agree we should keep a consistent API.

@errcw

View changes

Show outdated Hide outdated main.go
@errcw

View changes

Show outdated Hide outdated main.go
@errcw

View changes

Show outdated Hide outdated package.go
@slimsag

This comment has been minimized.

Show comment
Hide comment
@slimsag

slimsag Aug 17, 2014

Member

I will update this PR once #41 is completed.

Member

slimsag commented Aug 17, 2014

I will update this PR once #41 is completed.

@slimsag

This comment has been minimized.

Show comment
Hide comment
@slimsag

slimsag Aug 17, 2014

Member

I've merged #41 here and made the fixes you suggested.

Member

slimsag commented Aug 17, 2014

I've merged #41 here and made the fixes you suggested.

errcw added a commit that referenced this pull request Aug 18, 2014

Merge pull request #43 from slimsag/restrict
Add -restrict option to restrict symbol generation to JSON file.

@errcw errcw merged commit 2014886 into go-gl:master Aug 18, 2014

@slimsag slimsag deleted the slimsag:restrict branch Aug 18, 2014

@slimsag slimsag referenced this pull request Aug 22, 2014

Closed

switch to Glow #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment