Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis to run with supported Go versions #76

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@pwaller
Copy link
Member

commented Apr 11, 2019

Also, drop go tool vet which isn't supported anymore, and is also incorporated in go test.

This PR will also include the content of #75 once travis is passing, with the fixes requested by @dmitshur. Edit: see that PR, those changes were incorrect so I'm merging this indepdendently.

Update Travis to run with supported Go versions
Also, drop `go tool vet` which isn't supported anymore, and is also incorporated in `go test`.

@pwaller pwaller merged commit b3d77e0 into master Apr 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pwaller pwaller deleted the update-travis-fix-docstrings branch Apr 11, 2019

- 1.10.0
- 1.6.2
- 1.11.8
- 1.12.3

This comment has been minimized.

Copy link
@dmitshur

dmitshur Apr 11, 2019

Member

We can simplify this to always use the latest patch versions and not having to update the travis config when new ones come out:

- 1.12.x
- 1.11.x
@@ -13,5 +13,4 @@ install:
script:
- go get -t -v ./...
- diff -u <(echo -n) <(gofmt -d -s .)
- go tool vet .

This comment has been minimized.

Copy link
@dmitshur

dmitshur Apr 11, 2019

Member

go test runs a subset of of vet checks, so it’s still useful to run vet. It should be done this way now:

- go vet ./...
@pwaller

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

@dmitshur ah, great - would you mind doing those? I've ran out of time for now.

dmitshur added a commit that referenced this pull request Apr 14, 2019

Travis: use latest patch versions, re-add go vet
Specifying latest patch versions means less .travis.yml file maintenance for us.

Re-order the versions so that the current version (1.12) is listed first, and
the older version (1.11) is listed second.

Re-add go vet since it runs additional valuable checks on top of the ones that
go test runs.

Updates #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.