Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
client: don't do version discovery when version="" #27
Conversation
| - serviceURL, err = getAPIVersionURL(apiURLVersionInfo, requestedVersion) | ||
| - if err != nil { | ||
| - return "", err | ||
| + if apiVersion != "" { |
wallyworld
Oct 26, 2016
•
Edited 1 time
-
wallyworld
Oct 26, 2016
Owner
Edited 1 time
-
Oct 26, 2016
maybe invert this to avoid the indented block
if apiVersion == "" {
return blah
}
// do version stuff
...
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose |
jujubot
merged commit 807a92a
into
go-goose:v1
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedOct 26, 2016
If the user specifies no API version at all, don't
perform version discovery, and just return the URL
reported by the authentication response. This is to
support Juju's use of the "product-streams" service
entry for simplestreams data.