Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nova: omit "id" and "serverId" from attach request #28

Merged
merged 1 commit into from Nov 3, 2016
Merged

nova: omit "id" and "serverId" from attach request #28

merged 1 commit into from Nov 3, 2016

Conversation

axw
Copy link
Member

@axw axw commented Nov 3, 2016

When POSTing to os-volume_attachments, we should not
be passing anything for "id" or "serverId". Set these
to omitempty.

@axw
nova: omit "id" and "serverId" from attach request
f381998 
When POSTing to os-volume_attachments, we should not
be passing anything for "id" or "serverId". Set these
to omitempty.
@axw
Copy link
Member Author

axw commented Nov 3, 2016

See: http://developer.openstack.org/api-ref/compute/?expanded=attach-a-volume-to-an-instance-detail

@axw
Copy link
Member Author

axw commented Nov 3, 2016

$$merge$$

@jujubot
Copy link
Member

jujubot commented Nov 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose

@jujubot jujubot merged commit 328e6b2 into go-goose:v1 Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axw @jujubot @wallyworld