Add additional potential domain env vars #36

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Jamstah commented Nov 29, 2016

Potential variables for the domain are listed in this openstack doc: http://docs.openstack.org/developer/python-openstackclient/authentication.html

Jamstah commented Dec 13, 2016

@axw would you mind reviewing this one?

This is probably fine but I just want some clarification.

"OS_DOMAIN_NAME",
+ "OS_DEFAULT_DOMAIN",
@mjs

mjs Dec 13, 2016

I know very little about OpenStack. Can you explain why you chose these env vars specifically? There's more listed here: http://docs.openstack.org/developer/python-openstackclient/authentication.html#authenticating-using-identity-server-api-v3

Jamstah commented Dec 13, 2016

Do you mean the _ID ones? Could be a good idea to add them but I don't know goose so it would need testing to check it still works, or if it would need extending to cope.

I choose them based on the open stack doc and my experience, and guessed at a sensible order. I haven't checked which ones the open stack command line reads, or their preference order, that could be another thing to do.

What do you think?

mjs commented Dec 14, 2016

Sounds OK to me. Ship it :)

mjs approved these changes Dec 14, 2016

Owner

wallyworld commented Mar 16, 2017

Closing this PR as support for the extra env vars was recently added in a different PR.

@wallyworld wallyworld closed this Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment