Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add additional potential domain env vars #36
Conversation
Jamstah
commented
Dec 13, 2016
|
@axw would you mind reviewing this one? |
| "OS_DOMAIN_NAME", | ||
| + "OS_DEFAULT_DOMAIN", |
mjs
Dec 13, 2016
I know very little about OpenStack. Can you explain why you chose these env vars specifically? There's more listed here: http://docs.openstack.org/developer/python-openstackclient/authentication.html#authenticating-using-identity-server-api-v3
Jamstah
commented
Dec 13, 2016
|
Do you mean the _ID ones? Could be a good idea to add them but I don't know goose so it would need testing to check it still works, or if it would need extending to cope. I choose them based on the open stack doc and my experience, and guessed at a sensible order. I haven't checked which ones the open stack command line reads, or their preference order, that could be another thing to do. What do you think? |
mjs
commented
Dec 14, 2016
|
Sounds OK to me. Ship it :) |
|
Closing this PR as support for the extra env vars was recently added in a different PR. |
Jamstah commentedNov 29, 2016
Potential variables for the domain are listed in this openstack doc: http://docs.openstack.org/developer/python-openstackclient/authentication.html