/goose

Remove Content-Type header for payloadless request #37

Merged
merged 1 commit into from Nov 30, 2016

Conversation

Reviewers

@bz2 bz2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gnuoy @bz2 @jujubot
@gnuoy

gnuoy commented Nov 30, 2016

If a call out to the OpenStack API does not contain a
payload then do not set a Content-Type header as this
causes the Request to fail for OpenStack Mitaka+
deployments. Fixes lp:1625624

QA Steps

To reproduce the problem run the steps below. The final secgroup-list should not return
any security groups for this environment if Juju has cleaned up properly.

$ juju bootstrap
$ nova secgroup-list | grep jujutest     
$ time juju destroy-environment --yes jujutest                          
$ nova secgroup-list | grep jujutest
@gnuoy
Remove Content-Type header for payloadless request 
If a call out to the OpenStack API does not contain a
payload then do not set a Content-Type header as this
causes the Request to fail for OpenStack Mitaka+
deployments. Fixes lp:1625624
6275fae
@bz2

bz2 approved these changes Nov 30, 2016
View changes

Looks good, thanks!

@bz2
Contributor

bz2 commented Nov 30, 2016

$$merge$$
@jujubot
Member

jujubot commented Nov 30, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose
@jujubot
Member

jujubot commented Nov 30, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-goose/29
@bz2
Contributor

bz2 commented Nov 30, 2016

$$retry$$

--- FAIL: TestRunSuccess (0.00s)
FAIL
FAIL	gopkg.in/goose.v1/sync	0.020s

That... is not something this branch in any way touches, perhaps the 1ms timeout is too optimistic given load.
@jujubot
Member

jujubot commented Nov 30, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose

@jujubot jujubot merged commit 8f055ce into go-goose:v1 Nov 30, 2016

@bz2 bz2 referenced this pull request in juju/juju Dec 2, 2016

Merged

dependencies.tsv: Update goose for secgroup fix #6651

jujubot added a commit to juju/juju that referenced this pull request Dec 2, 2016

@jujubot
Merge pull request #6651 from bz2/master_goose_secgroup_1625624 
dependencies.tsv: Update goose for secgroup fix

Fixes lp:1625624 for develop.

With newer versions of openstack, goose fails to delete
security groups because it's sending POST requests with
a Content-Type but no body. Update the goose dependency
to pick up Liam's fix.

QA steps
----

See go-goose/goose#37
98cc6c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment