Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added more volume attachment functionality. #6
Conversation
wallyworld
reviewed
Mar 31, 2015
| + requestData := goosehttp.RequestData{} | ||
| + url := fmt.Sprintf("%s/%s/%s/%s", apiServers, serverId, apiVolumeAttachments, attachmentId) | ||
| + err := c.client.SendRequest(client.DELETE, "compute", url, &requestData) | ||
| + if errors.IsNotFound(err) { |
kat-co
Apr 2, 2015
Contributor
The endpoint not existing? I don't know how common it is, but it's a definite possibility since this is supported only if the OpenStack instance supports volume extensions.
wallyworld
reviewed
Mar 31, 2015
| c.Check(volAttachment.ServerId, gc.Equals, instance.Id) | ||
| c.Check(volAttachment.VolumeId, gc.Equals, "volume-id") | ||
| + | ||
| + // Test listing volumes. |
kat-co
Apr 2, 2015
Contributor
If they were unit tests, I would agree. As integration tests, I think they cover a nice cross-section of the code without duplication of effort.
wallyworld
reviewed
Mar 31, 2015
| + } | ||
| + } | ||
| + | ||
| + return fmt.Errorf("no such attachment id: %v", attachId) |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose |
|
Build failed: Merging failed |
added a commit
that referenced
this pull request
Apr 9, 2015
mitechie
merged commit a591935
into
go-goose:v1
Apr 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kat-co commentedMar 30, 2015