Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing error-check in AutoMigrate #5283

Merged
merged 1 commit into from Apr 22, 2022
Merged

fix missing error-check in AutoMigrate #5283

merged 1 commit into from Apr 22, 2022

Conversation

glebarez
Copy link
Contributor

@glebarez glebarez commented Apr 21, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Error check was missing in AutoMigrate.
Due to this miss, errors of underlying drivers might not be delivered, resulting in misleading error texts.
Example of such behavior is showed in #5282, which is duplicate column name: id but real error was in SQLite driver, namely invalid ddl

User Case Description

@jinzhu jinzhu merged commit 395606a into go-gorm:master Apr 22, 2022
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants