Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MigrateColumn):declared different type without length #5465

Merged
merged 1 commit into from Jun 29, 2022

Conversation

a631807682
Copy link
Contributor

@a631807682 a631807682 commented Jun 28, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

close #5462

User Case Description

// check size
if length, ok := columnType.Length(); length != int64(field.Size) {
if length > 0 && field.Size > 0 {
alterColumn = true
} else {
// has size in data type and not equal
// Since the following code is frequently called in the for loop, reg optimization is needed here
matches := regRealDataType.FindAllStringSubmatch(realDataType, -1)
Copy link
Contributor Author

@a631807682 a631807682 Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove regRealDataType because it is not match anything after #5088

@jinzhu jinzhu merged commit 235c093 into go-gorm:master Jun 29, 2022
32 checks passed
@a631807682 a631807682 deleted the fix_migrate_column branch Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants