Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migrator in transaction #64

Merged
merged 1 commit into from Feb 23, 2022
Merged

fix migrator in transaction #64

merged 1 commit into from Feb 23, 2022

Conversation

Goxiaoy
Copy link
Contributor

@Goxiaoy Goxiaoy commented Feb 22, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

go-sql-driver/mysql#1213 (comment)

Fix migrator issue in a transaction

User Case Description

@jinzhu
Copy link
Member

@jinzhu jinzhu commented Feb 23, 2022

does it causing issues? seems we are not reusing the rows?

@Goxiaoy
Copy link
Contributor Author

@Goxiaoy Goxiaoy commented Feb 23, 2022

In the following line

columns, rowErr := m.DB.Raw(columnTypeSQL, currentDatabase, stmt.Table).Rows()

busy buffer error will be raised if this migration happens in a transactional db instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants