Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retrieve users and user permission scopes #28

Merged
merged 8 commits into from
Oct 20, 2019

Conversation

jfchevrette
Copy link
Contributor

I had a need to allow bot admins to list and view user permissions.

This PR adds the following functionnality:

  • Retrieve bot users
  • Retrieve permission scopes for a specific user

As I'm fairly new to go, please let me know if you see any mistakes or things that should be improved in this PR

auth_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fgrosse fgrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request: it looks pretty good and you covered the two new functions with unit tests 👍

I think we should also update the "Unreleased" section of the CHANGELOG.md and I had some small comments but overall LGTM 😎

auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fgrosse fgrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and sorry for taking so long with the final review :)

@fgrosse fgrosse merged commit 9018c71 into go-joe:master Oct 20, 2019
@jfchevrette jfchevrette deleted the add_auth_get_permissions branch August 24, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants