Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcdv3 client won't return error when no endpoint is available #1009

Merged
merged 1 commit into from Sep 13, 2020

Conversation

wayjam
Copy link
Contributor

@wayjam wayjam commented Aug 30, 2020

Kit 's etcdv3 client would not return any error if no endpoint is avilable now.

  1. Adding an option to make etcd client will connect happen in background returning the client object before initial connect.
  2. Add two test about creating new etcd client.

Releated Commit:

Releated Issues:

sd/etcdv3/client_test.go Outdated Show resolved Hide resolved
sd/etcdv3/example_test.go Outdated Show resolved Hide resolved
sd/etcdv3/client.go Outdated Show resolved Hide resolved
sd/etcdv3/client.go Outdated Show resolved Hide resolved
@wayjam
Copy link
Contributor Author

wayjam commented Aug 30, 2020

@peterbourgon updated

@wayjam wayjam requested a review from peterbourgon Sep 1, 2020
@Joeluro9
Copy link

Joeluro9 commented Sep 11, 2020

@peterbourgon Pls handle the Pr

@wayjam
Copy link
Contributor Author

wayjam commented Sep 12, 2020

Hi, @peterbourgon this PR is waiting for re-review.

@peterbourgon
Copy link
Member

peterbourgon commented Sep 13, 2020

Nice! Thanks for the tests, especially.

@peterbourgon peterbourgon merged commit 4133f7f into go-kit:master Sep 13, 2020
2 checks passed
@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants