Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log stdlibadapter when prefixed #1036

Merged
merged 4 commits into from Nov 25, 2020

Conversation

soven
Copy link
Contributor

@soven soven commented Nov 16, 2020

No description provided.

log/stdlib.go Outdated
@@ -49,6 +52,11 @@ func MessageKey(key string) StdlibAdapterOption {
return func(a *StdlibAdapter) { a.messageKey = key }
}

// Prefix sets value of the prefix for the actual log message. By default, there's no prefix.
Copy link
Member

@peterbourgon peterbourgon Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does setting the prefix do?

Copy link
Contributor Author

@soven soven Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows client code to use the adapter for stdlib logger which is set by the prefix. There is an example in the issue.

Copy link
Member

@peterbourgon peterbourgon Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some more detail to the doc comment?

Copy link
Contributor Author

@soven soven Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. done

log/stdlib.go Show resolved Hide resolved
@soven soven requested a review from peterbourgon Nov 24, 2020
@soven
Copy link
Contributor Author

soven commented Nov 24, 2020

looks like something wrong with the CI

log/stdlib.go Outdated Show resolved Hide resolved
@peterbourgon peterbourgon merged commit a055839 into go-kit:master Nov 25, 2020
2 checks passed
@peterbourgon
Copy link
Member

peterbourgon commented Nov 25, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants