Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gauge.Add #428

Merged
merged 1 commit into from Jan 11, 2017
Merged

Added Gauge.Add #428

merged 1 commit into from Jan 11, 2017

Conversation

dlmiddlecote
Copy link

@dlmiddlecote dlmiddlecote commented Jan 10, 2017

Pull request for issue #393

}

// Add implements metrics.Gauge.
func (g *Gauge) Add(delta float64) {
Copy link
Author

@dlmiddlecote dlmiddlecote Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this could be better, but couldn't see any way in circonus-gometrics to get the value of a Gauge.

Copy link
Member

@peterbourgon peterbourgon Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Circonus has a very... esoteric view of the world

@peterbourgon
Copy link
Member

peterbourgon commented Jan 11, 2017

Yeah, this is great! I don't have a single thing I'd add. Thanks so much!

@peterbourgon peterbourgon merged commit 32a6fc8 into go-kit:master Jan 11, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants