Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pact test due to breaking api change #720

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@basvanbeek
Copy link
Member

basvanbeek commented Jun 11, 2018

No description provided.

@@ -16,7 +16,6 @@ func TestPactStringsvcUppercase(t *testing.T) {
}

pact := dsl.Pact{
Port: 6666,

This comment has been minimized.

Copy link
@peterbourgon

peterbourgon Jun 11, 2018

Member

How is this specified, now?

This comment has been minimized.

Copy link
@basvanbeek

basvanbeek Jun 11, 2018

Author Member

not sure, examples didn't show anything similar.. I wanted to test it on CI as it seemed too much hassle to do locally... documentation is lacking w.r.t. the changes or it's buried somewhere deep :(

This comment has been minimized.

Copy link
@basvanbeek

basvanbeek Jun 11, 2018

Author Member

@peterbourgon I see none of our CI environments actually runs it... do you have a local setup to test against?

@peterbourgon peterbourgon merged commit fadd127 into go-kit:master Jun 18, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 78.493%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.