Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics/internal/convert: use method value insetad of lambda #767

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@quasilyte
Copy link
Contributor

quasilyte commented Oct 1, 2018

Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.

metrics/internal/convert: use method value insetad of lambda
Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.
@quasilyte

This comment has been minimized.

Copy link
Contributor Author

quasilyte commented Oct 1, 2018

CI failure looks unrelated to the change:

#!/bin/bash -eo pipefail
go get -t github.com/go-kit/kit/...

# github.com/miekg/dns
../../miekg/dns/msg_helpers.go:271:8: undefined: strings.Builder
../../miekg/dns/serve_mux.go:43:9: undefined: strings.Builder
Exited with code 2

@peterbourgon peterbourgon merged commit 81cf14a into go-kit:master Oct 1, 2018

2 of 3 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.3%) to 79.06%
Details

@quasilyte quasilyte deleted the quasilyte:quasilyte/unlambda branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.