Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing icons errors in IDEA 13 EAP #263

Merged
merged 2 commits into from Nov 14, 2013

Conversation

Projects
None yet
2 participants
@dlsniper
Copy link
Member

commented Nov 10, 2013

This fixes the missing icon errors in latest IDEA 13 EAP

@dlsniper

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2013

Sorry, I've spent my whole day today trying to fix this the proper way.
I've tried moving the icons into following paths relative to the root directory of the plugin:

  • /icons
  • /resources/icons
  • /src/resources/icons
  • /src/ro/../icons
  • /src/ro/../resources/icons

But nothing. There's no clear error message, just the stack trace below and also there's no documentation I could find for where / how to properly store resources for plugins

Right now the icon is not visible in the tools menu and in the contextual menu for the 'Go' submenu.

I'll try asking on forums and link back to this issue.

Can't find icon in '/icons/go_16x16.png' near class com.intellij.openapi.actionSystem.DefaultActionGroup: Can't find icon in '/icons/go_16x16.png' near class com.intellij.openapi.actionSystem.DefaultActionGroup
java.lang.RuntimeException: Can't find icon in '/icons/go_16x16.png' near class com.intellij.openapi.actionSystem.DefaultActionGroup
    at com.intellij.openapi.util.IconLoader.findIcon(IconLoader.java:195)
    at com.intellij.openapi.actionSystem.impl.ActionManagerImpl$1.compute(ActionManagerImpl.java:456)
    at com.intellij.openapi.util.IconLoader$LazyIcon.getOrComputeIcon(IconLoader.java:430)
    at com.intellij.openapi.util.IconLoader.getDisabledIcon(IconLoader.java:260)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.e(ActionMenu.java:199)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.c(ActionMenu.java:163)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.<init>(ActionMenu.java:68)
    at com.intellij.openapi.actionSystem.impl.Utils.fillMenu(Utils.java:312)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.g(ActionMenu.java:278)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.access$400(ActionMenu.java:41)
    at com.intellij.openapi.actionSystem.impl.ActionMenu$MenuListenerImpl.menuSelected(ActionMenu.java:232)
    at javax.swing.JMenu.fireMenuSelected(JMenu.java:1043)
    at javax.swing.JMenu$MenuChangeListener.stateChanged(JMenu.java:1122)
    at javax.swing.DefaultButtonModel.fireStateChanged(DefaultButtonModel.java:349)
    at javax.swing.DefaultButtonModel.setSelected(DefaultButtonModel.java:232)
    at javax.swing.JMenu.setSelected(JMenu.java:311)
    at javax.swing.JMenu.menuSelectionChanged(JMenu.java:1190)
    at com.intellij.openapi.actionSystem.impl.ActionMenu.menuSelectionChanged(ActionMenu.java:206)
    at javax.swing.MenuSelectionManager.setSelectedPath(MenuSelectionManager.java:118)
    at javax.swing.plaf.basic.BasicMenuUI$Handler.mouseEntered(BasicMenuUI.java:511)
    at java.awt.Component.processMouseEvent(Component.java:6514)
    at javax.swing.JComponent.processMouseEvent(JComponent.java:3320)
    at java.awt.Component.processEvent(Component.java:6270)
    at java.awt.Container.processEvent(Container.java:2229)
    at java.awt.Component.dispatchEventImpl(Component.java:4861)
    at java.awt.Container.dispatchEventImpl(Container.java:2287)
    at java.awt.Component.dispatchEvent(Component.java:4687)
    at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
    at java.awt.LightweightDispatcher.trackMouseEnterExit(Container.java:4620)
    at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4474)
    at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
    at java.awt.Container.dispatchEventImpl(Container.java:2273)
    at java.awt.Window.dispatchEventImpl(Window.java:2719)
    at java.awt.Component.dispatchEvent(Component.java:4687)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:735)
    at java.awt.EventQueue.access$200(EventQueue.java:103)
    at java.awt.EventQueue$3.run(EventQueue.java:694)
    at java.awt.EventQueue$3.run(EventQueue.java:692)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
    at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
    at java.awt.EventQueue$4.run(EventQueue.java:708)
    at java.awt.EventQueue$4.run(EventQueue.java:706)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:705)
    at com.intellij.ide.IdeEventQueue.e(IdeEventQueue.java:696)
    at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:520)
    at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:335)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)
@dlsniper

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2013

Here's the thread I've opened on jetbrains devnet: http://devnet.jetbrains.com/message/5503030#5503030
Let me know which solution would you prefer in this case.

Thanks.

@dlsniper

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2013

I've had a bit of time and I've added the missing icons. Strangely enough, this was working out of the box on PHPStorm (I'm working on adding support for the other JetBrains IDEs but it's not a high priority task right now).

Feel free to merge when you can.

Thanks.

@dlsniper

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2013

@mtoader please don't forget to press the merge button on this one when you got some spare time ;)
Thanks.

@mtoader

This comment has been minimized.

Copy link
Member

commented Nov 14, 2013

Damn .. i don't get notifications properly :). Sorry. Thanks for pinging me.

mtoader added a commit that referenced this pull request Nov 14, 2013

Merge pull request #263 from dlsniper/fix-icons
Fix missing icons errors in IDEA 13 EAP

@mtoader mtoader merged commit e6fd9f9 into go-lang-plugin-org:master Nov 14, 2013

@dlsniper dlsniper deleted the dlsniper:fix-icons branch Nov 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.