Export AddRequest Struct variables in add.go

[nohupped]

wrote get methods to struct AddRequest in add.go, as the struct variables are not global, and it would be easy if an add request wants to be compared with another one before populating it.

[liggitt]

All the request structs except AddRequest and ModifyRequest export their fields... I don't really see anything special about those that should be different. I think I'd be ok with just exporting DN and Attributes in AddRequest

[nohupped]

That's so kind of you, Thank you. I was wondering about modifying DN of the addrequest. One issue I faced was while comparing AD and LDAP add requests, where AD was returning realms like "CN=abc,OU=xyz,DC=example,DC=com" whereas LDAP was returning "cn=abc,ou=xyz,dc=example,dc=com" (uppercase/lowercase difference). If adding this feature is something redundant, which can be done using a ModifyRequest, I will follow that.

[liggitt]

that seems more like a normalization issue, not specific to add requests

[nohupped]

Gotcha, Thank you.

[nohupped]

@liggitt Would you prefer to keep the get methods, or keep the struct fields exported like DN and Attributes, like in del.go? My opinion is it would be great if you prefer to keep it exported in the latter way, as users will get the freedom to write methods to modify the original struct with their own wrapper structs in their projects as

type AddRequest struct {
    *ldap.AddRequest
}

func (a *AddRequest) SetDN(dn string) {
    a.DN = dn
}```

[liggitt]

yeah, I would just export the fields

[nohupped]

Thank you

[vetinari]

This is also in 9b058ac (part of #49)

I need the exported ones to render the add / mod requests as LDIF

[nohupped]

I was wondering, if it would be fine to expose the Attribute struct's fields

type Attribute struct {
    attrType string
    attrVals []string
}

in add.go as well?

[liggitt]

I think it's ok to expose those, though I'd like to rename them to match the LDAP names before exposing them, so Type and Vals

[nohupped]

Hi @liggitt I was wondering if this can be merged, as we are using a forked one for our project temporarily.

[liggitt]

@nohupped, merged, sorry for the delay
@vetinari, fyi, also broke out the change to export fields in ModifyRequest structs into #67 and merged that as well

[nohupped]

Thank you @liggitt