Skip to content

Use 4-byte UTF-8 by default #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Use 4-byte UTF-8 by default #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d99eb63
Use 4-byte UTF-8 by default
dveeden Feb 4, 2025
93890e3
Merge branch 'master' into utf8mb4_default
lance6716 Feb 7, 2025
e1779b2
update comment
dveeden Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func (c *Conn) writeAuthHandshake() error {
data[11] = 0x00

// Charset [1 byte]
// use default collation id 33 here, is `utf8mb3_general_ci`
// use default collation id 255 here, is `utf8mb4_0900_ai_ci`
collationName := c.collation
if len(collationName) == 0 {
collationName = DEFAULT_COLLATION_NAME
Expand Down
8 changes: 4 additions & 4 deletions mysql/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,10 @@ const (
DEFAULT_IPV6_ADDR = "[::1]:3306"
DEFAULT_USER = "root"
DEFAULT_PASSWORD = ""
DEFAULT_FLAVOR = "mysql"
DEFAULT_CHARSET = "utf8"
DEFAULT_COLLATION_ID uint8 = 33
DEFAULT_COLLATION_NAME string = "utf8_general_ci"
DEFAULT_FLAVOR = MySQLFlavor
DEFAULT_CHARSET = "utf8mb4"
DEFAULT_COLLATION_ID uint8 = 255
DEFAULT_COLLATION_NAME string = "utf8mb4_0900_ai_ci"
)

const (
Expand Down
Loading