Skip to content

[BUG] Client secret not verified if not provided #156

@sywesk

Description

@sywesk

Hello,

While trying to get your lib working on my project, I saw that using Server.HandleTokenRequest with no secret leads to a valid token being generated. See the attached picture as a proof.

I used a sample configuration to get it to work:

	manager := manage.NewDefaultManager()
	manager.MustTokenStorage(store.NewMemoryTokenStore())

	clientStore := store.NewClientStore()
	clientStore.Set("000000", &models.Client{
		ID:     "000000",
		Secret: "999999",
		Domain: "http://localhost",
	})
	manager.MapClientStorage(clientStore)

	srv := server.NewDefaultServer(manager)

Notes: Giving a bad secret results in an error being thrown. But no secret works.

token_with_no_secret

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions