Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Go Minimum Version Requirement #86

Open
jacobsantos opened this issue Aug 19, 2015 · 6 comments
Open

Increase Go Minimum Version Requirement #86

jacobsantos opened this issue Aug 19, 2015 · 6 comments
Labels
Milestone

Comments

@jacobsantos
Copy link
Member

Survey to increase Go version to 1.4 to allow for go generate and internal packages.

Some of the tools may actually require 1.5, but I think the types package should be fine whether they are used in 1.4 or 1.5.

@mattn

@mattn
Copy link
Member

mattn commented Aug 19, 2015

okay. I don't have any objection.

@jacobsantos
Copy link
Member Author

May only affect the go generate com tool, but there might be other reasons to go to minimum of 1.4 with the standard lib. But the syscall tool has been split from the standard lib a few versions ago. I would like to update to the external tools at least. That shouldn't necessarily obsolete support for older versions.

Currently, Appveyor only supports (by default) 1.4 and that might increase to 1.5 in a few days or weeks. I will have to work on that later to get more versions tested. Along with 32-bit versions.

I don't know. At this point, I would assume that anyone using Go is upgrading to the latest versions for stability and features.

@jacobsantos jacobsantos added this to the v2.0 milestone Sep 16, 2015
@jacobsantos jacobsantos changed the title Increase Go Requirement to 1.4 Increase Go Minimum Version Requirement Nov 3, 2015
@jacobsantos
Copy link
Member Author

I think at some point version 2.0 will take care of this. Just depends on what version is out at the time.

@mattn I am thinking that whenever 2.0 is released one version previous should be used as the minimum. Right now there isn't a whole lot of reason to do this. Last couple of Go releases have really just focused on stability and converting the Go compiler over to Go.

I'm not sure what 1.6 or 1.7 is going to have, but unless it has serious language constructs that make developing easier and faster. I don't see a point.

I'm going to continue focusing on stability and writing test cases and eventually more documentation for this library. Also implementing more of the COM port.

@mattn
Copy link
Member

mattn commented Nov 3, 2015

I'm going to continue focusing on stability and writing test cases and eventually more documentation for this library. Also implementing more of the COM port.

I want to fix the feature of go-ole until 2.0. especially directory structure, breaking compatibility or not.

@jacobsantos
Copy link
Member Author

@mattn Write tickets and I will see what I can do. Let me know what you want to do, so that I can develop and plan accordingly.

I hadn't planned on changing the directory structure. Most of directory structure changes are being done in separate repositories. It is a good thing too, since I am not sure the early directory structure changes were that great and I'm not sure the current go-ole/com directory changes are that great either. I can kind of see how well they work given that you can remove a lot of files from the base structure for the differences between linux, windows shared library and windows w/ cgo. Along with potentially a single file for tests. I do think keeping the tests with the actual files is better, because linux tests are going to be different than windows tests.

@mattn
Copy link
Member

mattn commented Nov 3, 2015

Okay. If it keeps compatibility, let's make minor version. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants