Add size flag to demo pinger #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a command line flag to the demo pinger which lets the user set the the size of the ICMP payload. This is useful for testing. The default is set at 16 which is the default for an unconfigured pinger. Signed-off-by: Charlie Jonas <charlie@charliejonas.co.uk>
SuperQ
reviewed
Feb 11, 2021
SuperQ
approved these changes
Feb 13, 2021
sparrc
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line flag to the demo pinger which lets the user set the the size of the ICMP payload. The default is
set at 16 which is the current default for an unconfigured pinger. Mainly useful for testing purposes.