Add a POST request handler to the direct provider #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o1egl
force-pushed
the
post_direct_handler
branch
2 times, most recently
from
beb9c52
to
80355b0
Compare
Pull Request Test Coverage Report for Build 144177369
💛 - Coveralls |
umputun
requested changes
Jun 22, 2020
provider/direct.go
Outdated
| if contentType == "application/json" { | ||
| var credentials Credentials | ||
| if err := json.NewDecoder(r.Body).Decode(&credentials); err != nil { | ||
| return Credentials{}, fmt.Errorf("failed to parse request body: %w", err) |
There was a problem hiding this comment.
pkg/errors already in the list of deps and used in other places. i.e. errors.Wrap(err, "failed to parse request body") will be consistent
provider/direct.go
Outdated
| @@ -13,6 +16,13 @@ import ( | |||
| "github.com/go-pkgz/auth/token" | |||
| ) | |||
|
|
|||
| const ( | |||
| // MaxHTTPBodySize defines max http body size | |||
| MaxHTTPBodySize = megabyte | |||
There was a problem hiding this comment.
MaxHTTPBodySize = 1024*1024 will be easier to read
provider/direct.go
Outdated
| @@ -37,21 +47,48 @@ func (f CredCheckerFunc) Check(user, password string) (ok bool, err error) { | |||
| return f(user, password) | |||
| } | |||
|
|
|||
| // Credentials holds user credentials | |||
| type Credentials struct { | |||
There was a problem hiding this comment.
I don't think this struct supposed to be exposed. If so, making it credentials makes more sense
provider/direct.go
Outdated
| func (p DirectHandler) LoginHandler(w http.ResponseWriter, r *http.Request) { | ||
| user, password := r.URL.Query().Get("user"), r.URL.Query().Get("passwd") | ||
| aud := r.URL.Query().Get("aud") | ||
| if r.Body != nil { |
There was a problem hiding this comment.
probably, moving this body wrapping to getCredentials will make this part closer to the consumer and more readable
o1egl
force-pushed
the
post_direct_handler
branch
from
80355b0
to
52634b8
Compare
o1egl
force-pushed
the
post_direct_handler
branch
from
52634b8
to
6087a84
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case it's required to send user provided input data in POST request. This PR adds
application/x-www-form-urlencodedandapplication/jsonencoded body processors to the direct handler.