From b6f416911606782ddb67ece4cc333c3185d57a47 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 13:45:09 +0330 Subject: [PATCH 01/12] add golangci to workflow --- .github/workflows/golangci-lint.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/workflows/golangci-lint.yml diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml new file mode 100644 index 0000000..727cbfd --- /dev/null +++ b/.github/workflows/golangci-lint.yml @@ -0,0 +1,11 @@ +name :"golangci-lint" + +on: + pull_request: + branches: [ main ] + +- name: golangci-lint + uses: golangci/golangci-lint-action@v3.7.0 + with: + go-version: '1.20' + From e34599a362aa73e7679cca723abd7c0822e7b020 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 13:58:05 +0330 Subject: [PATCH 02/12] update golangci-lint --- .github/workflows/golangci-lint.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 727cbfd..49291c7 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -1,11 +1,16 @@ -name :"golangci-lint" +name : "golangci-lint" on: pull_request: branches: [ main ] -- name: golangci-lint - uses: golangci/golangci-lint-action@v3.7.0 - with: - go-version: '1.20' - +jobs: + golangci: + runs-on: ubuntu-latest + steps: + - uses: golangci/golangci-lint-action@v3.7.0 + - name: golangci-lint + uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # 3.6.0 + with: + version: latest + go-version: '1.20' From d8f1002c68ae884b32a9c8b44899c09a61425ea3 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 14:10:35 +0330 Subject: [PATCH 03/12] update golangci-lint --- .github/workflows/golangci-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 49291c7..ecf2720 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -10,7 +10,7 @@ jobs: steps: - uses: golangci/golangci-lint-action@v3.7.0 - name: golangci-lint - uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # 3.6.0 + uses: golangci/golangci-lint-action@v3.7.0 with: version: latest go-version: '1.20' From b0f812b0925abd4dd51c21df3332993647c0fc2e Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 14:15:57 +0330 Subject: [PATCH 04/12] update golangci-lint --- .github/workflows/golangci-lint.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index ecf2720..c518f99 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -4,11 +4,18 @@ on: pull_request: branches: [ main ] +permissions: + contents: read + jobs: golangci: runs-on: ubuntu-latest steps: - - uses: golangci/golangci-lint-action@v3.7.0 + - uses: actions/checkout@v3 + - uses: actions/setup-go@v4 + with: + go-version: '1.20' + cache: false - name: golangci-lint uses: golangci/golangci-lint-action@v3.7.0 with: From e305b748ab3496e804263f9d3603439807985e70 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 14:29:30 +0330 Subject: [PATCH 05/12] update golangci-lint --- .github/workflows/golangci-lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index c518f99..14b8090 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -14,7 +14,6 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: '1.20' cache: false - name: golangci-lint uses: golangci/golangci-lint-action@v3.7.0 From acccc59c10e19c2c50fbd976639c44d1c444fc14 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 14:31:58 +0330 Subject: [PATCH 06/12] update golangci-lint --- .github/workflows/golangci-lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 14b8090..7b0fd08 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -19,4 +19,3 @@ jobs: uses: golangci/golangci-lint-action@v3.7.0 with: version: latest - go-version: '1.20' From f7b32cd411f83986c2978530c179ea500a9b76dd Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Tue, 5 Sep 2023 14:50:26 +0330 Subject: [PATCH 07/12] fix go-version 1.20 --- .github/workflows/golangci-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 7b0fd08..813b3f1 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -14,6 +14,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: + go-version: '1.20' cache: false - name: golangci-lint uses: golangci/golangci-lint-action@v3.7.0 From 8358852039f37642e629818be7671eacf98f51b5 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Sat, 9 Sep 2023 12:40:26 +0330 Subject: [PATCH 08/12] one file for all CI --- .github/workflows/ci.yml | 22 ++++++++++++++++++++++ .github/workflows/golangci-lint.yml | 22 ---------------------- 2 files changed, 22 insertions(+), 22 deletions(-) delete mode 100644 .github/workflows/golangci-lint.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac23f08..b5fe1be 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,4 +1,26 @@ # Source: https://github.com/actions/starter-workflows/blob/main/ci/go.yml +name : "golangci-lint" + +on: + pull_request: + branches: [ main ] + +permissions: + contents: read + +jobs: + golangci: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-go@v4 + with: + go-version: '1.20' + cache: false + - name: golangci-lint + uses: golangci/golangci-lint-action@v3.7.0 + with: + version: latest name: CI diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml deleted file mode 100644 index 813b3f1..0000000 --- a/.github/workflows/golangci-lint.yml +++ /dev/null @@ -1,22 +0,0 @@ -name : "golangci-lint" - -on: - pull_request: - branches: [ main ] - -permissions: - contents: read - -jobs: - golangci: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 - with: - go-version: '1.20' - cache: false - - name: golangci-lint - uses: golangci/golangci-lint-action@v3.7.0 - with: - version: latest From ba22e881c836d7a0fc4f5b68dd1313198c2851d9 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Sat, 9 Sep 2023 12:46:21 +0330 Subject: [PATCH 09/12] remove duplicate part --- .github/workflows/ci.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b5fe1be..1e3f30d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,9 @@ # Source: https://github.com/actions/starter-workflows/blob/main/ci/go.yml -name : "golangci-lint" +name: CI on: + push: + branches: [ main ] pull_request: branches: [ main ] @@ -22,15 +24,6 @@ jobs: with: version: latest -name: CI - -on: - push: - branches: [ main ] - pull_request: - branches: [ main ] - -jobs: # Test with EPUBCheck and send test coverage test-epubcheck: runs-on: ubuntu-latest From e3a7209103e26d75333873f36d5ebe1c0307aeca Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Sat, 9 Sep 2023 12:52:03 +0330 Subject: [PATCH 10/12] use go-version-file instead of go-version --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e3f30d..07e1e19 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: '1.20' + go-version-file: go.mod cache: false - name: golangci-lint uses: golangci/golangci-lint-action@v3.7.0 From 1c1745539f0a6ea824443e43b98378c58278d292 Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Sat, 9 Sep 2023 13:02:17 +0330 Subject: [PATCH 11/12] point specific tag for actions --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 07e1e19..a3d1d78 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,16 +11,17 @@ permissions: contents: read jobs: + # Test golangci-lint for go-version define in go.mod golangci: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4.0.0 + - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe #v4.1.0 with: go-version-file: go.mod cache: false - name: golangci-lint - uses: golangci/golangci-lint-action@v3.7.0 + uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc #v3.7.0 with: version: latest From 4ad9b6afe102582c7d8402238e2c03e51657310c Mon Sep 17 00:00:00 2001 From: monirzadeh <25131576+Monirzadeh@users.noreply.github.com> Date: Sat, 9 Sep 2023 13:05:16 +0330 Subject: [PATCH 12/12] run just on new pull request --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a3d1d78..c8198e9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,6 +24,7 @@ jobs: uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc #v3.7.0 with: version: latest + only-new-issues: true # Test with EPUBCheck and send test coverage test-epubcheck: