Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose SetLogLevel in cli #834

Closed
wants to merge 1 commit into from
Closed

feat: expose SetLogLevel in cli #834

wants to merge 1 commit into from

Conversation

iwpnd
Copy link
Sponsor Member

@iwpnd iwpnd commented Feb 25, 2022

Allow user to set a desired log level on startup with --log-level Level.
Omitting the flag results in the default INFO

Hey 馃憢

I got to one of my proposition from #831.
As options I went for the log levels that @gdey has already set - all I did is exposing SetLogLevel in the root.

Let me know if you prefer those levels for the flag instead:

very-verbose = TRACE
verbose = DEBUG
default = INFO
quiet = WARN
silent = ERROR

Where do the docs live actually? 馃

@coveralls
Copy link

coveralls commented Feb 25, 2022

Pull Request Test Coverage Report for Build 62aaf7955-PR-834

  • 3 of 26 (11.54%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 45.141%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/tegola/cmd/root.go 3 26 11.54%
Totals Coverage Status
Change from base Build ac85a37e4: -0.06%
Covered Lines: 5486
Relevant Lines: 12153

馃挍 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Since tegola is not using the centralized log package throughout the codebase yet, should we add a note to the flag to say it's only partially adopted at this point?

cmd/tegola/cmd/root.go Show resolved Hide resolved
Allow user to set a desired log level on startup with `--log-level Level`.
Omitting the flag results in the default INFO

fix: add options, labels as work in progress
@iwpnd
Copy link
Sponsor Member Author

iwpnd commented Feb 26, 2022

understood. I added the options and labelled the flag as a work in progress.

@iwpnd
Copy link
Sponsor Member Author

iwpnd commented Feb 28, 2022

@gdey since this is actually your work and not mine, are you okay with this?

@ARolek
Copy link
Member

ARolek commented Mar 1, 2022

closed in e593b4f

@ARolek ARolek closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants