Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from Travis to Actions #1183

merged 8 commits into from Dec 28, 2020


Copy link

@methane methane commented Dec 23, 2020


Travis didn't run even I removed macOS build. We need to move all tests to Actions.

Fixes #1176.


  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Copy link
Member Author

methane commented Dec 23, 2020

@julienschmidt We need to move from Travis to Github Actions because Travis stopped our jobs.
Could you remove Travis-CI from the required checks of the master branch?

@methane methane changed the title Linux on actions Move Travis to Actions Dec 23, 2020
@methane methane changed the title Move Travis to Actions Move tests from Travis to Actions Dec 23, 2020
Copy link
Member Author

methane commented Dec 23, 2020

This pull request doesn't report coverage because we need to run CI ASAP.

@julienschmidt julienschmidt merged commit a341cd1 into go-sql-driver:master Dec 28, 2020
@shogo82148 shogo82148 mentioned this pull request Mar 7, 2021
andygrunwald added a commit to andygrunwald/mysql that referenced this pull request Jul 31, 2021
* master: (93 commits)
  return unsigned in database type name when necessary (go-sql-driver#1238)
  add an invalid DSN test case (go-sql-driver#1235)
  refactoring (*textRows).readRow in a more clear way (go-sql-driver#1230)
  use utf8mb4 instead of utf8 in TestCharset (go-sql-driver#1228)
  improve readability follows go-staticcheck (go-sql-driver#1227)
  support Is comparison on MySQLError (go-sql-driver#1210)
  Wording correction in README (go-sql-driver#1218)
  noCopy implements sync.Locker (go-sql-driver#1216)
  Fix readme: MaxIdle is same or less than MaxOpen (go-sql-driver#1215)
  Drop support of Go 1.12 (go-sql-driver#1211)
  Release v1.6.0 (go-sql-driver#1197)
  add Go 1.16 to the build matrix (go-sql-driver#1198)
  Implement driver.Validator interface (go-sql-driver#1174)
  handling decoding pem error (go-sql-driver#1192)
  stop rounding times (go-sql-driver#1172)
  improve GitHub Actions workflows (go-sql-driver#1190)
  Move tests from Travis to Actions (go-sql-driver#1183)
  Fix go vet error (go-sql-driver#1173)
  README: Make usage code more friendly (go-sql-driver#1170)
  Fix a broken link to cleartext client side plugin (go-sql-driver#1165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Builds on Travis-CI have been temporarily disabled
2 participants