Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race on cancelling context passed to QueryContext #905

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@methane
Copy link
Member

methane commented Dec 4, 2018

Description

This pull request is based on #904.

#904 add one allocation for each rows, unless buffer size is increased by some reason.
This pull request increases the initial buffer size from 4KiB to 16KiB.
This will reduce number of allocations.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

methane added some commits Dec 3, 2018

fix
Increase default buffer size from 4KB to 16KB
Minimum buffer size is still 4KB.
This reduces reallocation.
@methane

This comment has been minimized.

Copy link
Member Author

methane commented Dec 4, 2018

@julienschmidt @shogo82148 Wold you take a look?

@julienschmidt

This comment has been minimized.

Copy link
Member

julienschmidt commented Dec 4, 2018

See #904

@methane methane referenced this pull request Dec 4, 2018

Closed

Truncate internal buffer when rows.Close() is called #904

4 of 5 tasks complete
@DoctorQ

This comment has been minimized.

Copy link

DoctorQ commented Dec 7, 2018

if choose other way,when can fix it!waiting for !

@DoctorQ

This comment has been minimized.

Copy link

DoctorQ commented Jan 3, 2019

@methane methane changed the title Increase buffer size fix race on cancelling context passed to QueryContext Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.