Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a shadow in server.gotmpl #1082

Merged
merged 2 commits into from Jun 29, 2017
Merged

Conversation

arielt
Copy link
Contributor

@arielt arielt commented Jun 29, 2017

go vet reports shadowing in generated server.go
variable name changed in server.gotmpl

err name in server.gotmpl triggers shadow messages of go vet

Signed-off-by: Ariel Tubaltsev <tubaltzev@gmail.com>
run go generator for fix in server.gotmpl
@casualjim casualjim merged commit 2ea68fd into go-swagger:master Jun 29, 2017
@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #1082 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   72.18%   72.18%           
=======================================
  Files          21       21           
  Lines        6048     6048           
=======================================
  Hits         4366     4366           
  Misses       1217     1217           
  Partials      465      465
Impacted Files Coverage Δ
generator/bindata.go 66.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d507f49...9b4f044. Read the comment docs.

krishna2090 added a commit to krishna2090/go-swagger that referenced this pull request Jul 10, 2017
This reverts commit 2ea68fd, reversing
changes made to d507f49.
krishna2090 added a commit to krishna2090/go-swagger that referenced this pull request Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants