Acknowledge fix #1816 with go-openapi updates #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 27, 2018
| @@ -447,3 +447,24 @@ func TestServer_Issue1746(t *testing.T) { | |||
| assertRegexpInCode(t, `go:generate swagger generate server.+\-\-name\s+ExampleSwaggerServer`, string(gulp)) | |||
| assertRegexpInCode(t, `go:generate swagger generate server.+\-\-spec\s+`+tgtSpec, string(gulp)) | |||
| } | |||
|
|
|||
| func TestServer_Issue1816(t *testing.T) { | |||
There was a problem hiding this comment.
451-470 lines are duplicate of generator/server_test.go:168-187 (from dupl)
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 38 38
Lines 7539 7539
=======================================
Hits 6067 6067
Misses 996 996
Partials 476 476Continue to review full report at Codecov.
|
fredbi
force-pushed
the
fix-1816-embedded-spec
branch
2 times, most recently
from
4de9bf3
to
d6efc19
Compare
fredbi
changed the title
fredbi
force-pushed
the
fix-1816-embedded-spec
branch
from
d6efc19
to
a460d82
Compare
* update vendor: go-openapi/spec, go-openapi/loads Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix-1816-embedded-spec
branch
from
a460d82
to
556e634
Compare
|
@fredbi @casualjim Anything else required for this to be merged? |
casualjim
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
> NOTE: this is WIP and would require go-openapi/spec#87 and go-openapi/loads#22 to be merged.Signed-off-by: Frederic BIDON fredbi@yahoo.com