-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge fix #1816 with go-openapi updates #1818
Conversation
@@ -447,3 +447,24 @@ func TestServer_Issue1746(t *testing.T) { | |||
assertRegexpInCode(t, `go:generate swagger generate server.+\-\-name\s+ExampleSwaggerServer`, string(gulp)) | |||
assertRegexpInCode(t, `go:generate swagger generate server.+\-\-spec\s+`+tgtSpec, string(gulp)) | |||
} | |||
|
|||
func TestServer_Issue1816(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
451-470 lines are duplicate of generator/server_test.go:168-187
(from dupl
)
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 38 38
Lines 7539 7539
=======================================
Hits 6067 6067
Misses 996 996
Partials 476 476 Continue to review full report at Codecov.
|
4de9bf3
to
d6efc19
Compare
d6efc19
to
a460d82
Compare
* update vendor: go-openapi/spec, go-openapi/loads Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
a460d82
to
556e634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@fredbi @casualjim Anything else required for this to be merged? |
> NOTE: this is WIP and would require go-openapi/spec#87 and go-openapi/loads#22 to be merged.Signed-off-by: Frederic BIDON fredbi@yahoo.com