Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable is always executed in v3.5.0 #517

Closed
orsinium opened this issue Jul 5, 2021 · 1 comment
Closed

Variable is always executed in v3.5.0 #517

orsinium opened this issue Jul 5, 2021 · 1 comment
Labels
type: bug Something not working as intended.

Comments

@orsinium
Copy link

orsinium commented Jul 5, 2021

  • Task version: 3.5.0
  • Operating System: linux

Example Taskfile showing the issue

version: '3'

vars:
  VAR:
    sh: "false"

tasks:
  default:
    cmds:
      - "true"
    silent: true

Task 3.4.2:

$ task --version  
Task version: v3.4.2 (h1:DRATD5qavWC5FqpopJ/JcCelOMakFtGS7CubdZ/FiQY=)
$ task default VAR=1
# 0 exit code

Task 3.5.0:

$ ./bin/task --version    
Task version: v3.5.0 (h1:xPJ+jbd4mUwcpMpPLIIu/DX8wANPJqZbGL725Wc3QTA=)
$ ./bin/task default VAR=1
task: Command "false" in taskvars file failed: exit status 1
@orsinium orsinium added the type: bug Something not working as intended. label Jul 5, 2021
@andreynering
Copy link
Member

Hi @orsinium, thanks for reporting this!

I mitigated this in 945c72c, although it can still happen if you have a dotenv: declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something not working as intended.
Projects
None yet
Development

No branches or pull requests

2 participants