Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Check context error #598

Merged
merged 1 commit into from Nov 28, 2021
Merged

Conversation

sylv-io
Copy link
Contributor

@sylv-io sylv-io commented Nov 3, 2021

Fix #597

Check context error after running dependencies, to prevent false
negative precondition errors due to "context canceled".

Check context error after running dependencies, to prevent false
negative precondition errors due to "context canceled".

Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
@andreynering
Copy link
Member

@sylv-io Thanks for contributing again!

@andreynering andreynering merged commit a441b4b into go-task:master Nov 28, 2021
andreynering added a commit that referenced this pull request Nov 28, 2021
@sylv-io sylv-io deleted the fix/false_fail branch November 28, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preconditions fail even if condition was met
2 participants