Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deployment UI #414

Merged
merged 42 commits into from
Aug 3, 2021
Merged

feat: add deployment UI #414

merged 42 commits into from
Aug 3, 2021

Conversation

JayCeeJr
Copy link
Contributor

go-vela/community#111

Added Deployment form to UI.

@JayCeeJr JayCeeJr mentioned this pull request Jun 28, 2021
Closed
@JayCeeJr JayCeeJr marked this pull request as ready for review June 30, 2021 15:01
@JayCeeJr JayCeeJr requested a review from a team as a code owner June 30, 2021 15:01
@JayCeeJr JayCeeJr changed the title Feature/deployments UI feat: add deployment UI Jul 1, 2021
plyr4
plyr4 requested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall well done, very nice feature addition!
I left some feedback in the comments, let me know if you have questions.

src/elm/Help/Commands.elm Outdated Show resolved Hide resolved
src/elm/Help/Commands.elm Outdated Show resolved Hide resolved
src/elm/Api.elm Outdated Show resolved Hide resolved
src/elm/Main.elm Outdated Show resolved Hide resolved
src/elm/Main.elm Show resolved Hide resolved
src/elm/Pages/Deployments/Update.elm Outdated Show resolved Hide resolved
src/elm/Pages/Deployments/Update.elm Outdated Show resolved Hide resolved
src/elm/Crumbs.elm Outdated Show resolved Hide resolved
src/elm/Nav.elm Outdated Show resolved Hide resolved
src/scss/_main.scss Show resolved Hide resolved
@kneal kneal added the feature Indicates a new feature label Jul 13, 2021
JayCeeJr
JayCeeJr commented Jul 22, 2021
View reviewed changes
src/elm/Help/Commands.elm Outdated Show resolved Hide resolved
JayCeeJr
JayCeeJr commented Jul 22, 2021
View reviewed changes
src/elm/Help/Commands.elm Outdated Show resolved Hide resolved
@JayCeeJr JayCeeJr requested a review from plyr4 July 26, 2021 20:44
plyr4
plyr4 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME feature, and nice work!

@wass3r wass3r merged commit 45b11cf into go-vela:master Aug 3, 2021
@JayCeeJr JayCeeJr deleted the feature/deployments-ui branch August 4, 2021 14:41
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
@JayCeeJr
feat: add deployment UI (#414)
a472d19
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
@JayCeeJr
feat: add deployment UI (#414)
64c0aaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@JayCeeJr JayCeeJr

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JayCeeJr @wass3r @plyr4 @kneal @jchristensen5k