Allow adding prefix for fields with extends
tag
#1284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
==========================================
+ Coverage 57.37% 57.44% +0.06%
==========================================
Files 44 44
Lines 7813 7837 +24
==========================================
+ Hits 4483 4502 +19
- Misses 2773 2777 +4
- Partials 557 558 +1
Continue to review full report at Codecov.
|
Join Table Alias Name or prefix of the name, which is better?
instead of
|
IMO having just prefix is better here since it refers to what the column name of the query result should be changed to, it doesn't have to have anything in common with the table (the prefix I mean). |
Sorry to bother you, but would I be able to get an ETA on this review? This is kind of a blocking change for me. |
How to handle |
Maybe as if there was no argument? So the same as just |
@mskrip I think it's reasonable. |
Added new syntax like `extends('Prefix')` to enable matching all extended fields as 'PrefixFieldName'. Close #1270
@lunny Added test for that case |
@lunny ping |
@mskrip will do last review tomorrow morning. |
@lunny Okay, thank you |
@mskrip Thanks! |
Added new syntax like
extends('Prefix')
to enable matching allextended fields as
PrefixFieldName
.Close #1270