Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (v2): set the default line length to infinity (-1) #571

Merged
merged 1 commit into from May 6, 2020

Conversation

@laverya
Copy link
Contributor

@laverya laverya commented Jan 24, 2020

as suggested here: #166 (comment)

@laverya laverya requested a review from niemeyer Feb 11, 2020
@jjshoe
Copy link

@jjshoe jjshoe commented May 5, 2020

@niemeyer can we get this merged in?

@niemeyer niemeyer merged commit 0b1645d into go-yaml:v2 May 6, 2020
1 check passed
@niemeyer
Copy link
Contributor

@niemeyer niemeyer commented May 6, 2020

Done!

@niemeyer
Copy link
Contributor

@niemeyer niemeyer commented May 6, 2020

@laverya Thanks for the PR.

@laverya
Copy link
Contributor Author

@laverya laverya commented May 12, 2020

Is there any chance of this becoming a release soon @niemeyer? Or do we need to wait longer to see if objections are raised?

@niemeyer
Copy link
Contributor

@niemeyer niemeyer commented May 12, 2020

Wish conceded! I think we've waited enough.

I'm also thinking of tagging v3 in the next few days, and switching over to it as the main branch. Blockers are almost over.

marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 16, 2020
yaml.v2 contains a breaking change from
go-yaml/yaml#571

yaml.v2 2.2.8 does not have that change and also addresses the CVE that
was behind the move to yaml.v2 2.3.0.  This commit reverts to using
yaml.v2 2.2.8

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 16, 2020
yaml.v2 contains a breaking change from
go-yaml/yaml#571

yaml.v2 2.2.8 does not have that change and also addresses the CVE that
was behind the move to yaml.v2 2.3.0.  This commit reverts to using
yaml.v2 2.2.8

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
jpmcb pushed a commit to spf13/cobra that referenced this issue Oct 18, 2020
yaml.v2 contains a breaking change from
go-yaml/yaml#571

yaml.v2 2.2.8 does not have that change and also addresses the CVE that
was behind the move to yaml.v2 2.3.0.  This commit reverts to using
yaml.v2 2.2.8

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
dims added a commit to dims/yaml-1 that referenced this issue Nov 12, 2020
This reverts commit 0b1645d.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants