New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate tests correctly when headers are defined only on resource #1127

Merged
merged 3 commits into from Mar 17, 2017

Conversation

Projects
None yet
2 participants
@matteosuppo
Copy link
Contributor

matteosuppo commented Mar 17, 2017

Fix #1125

Signed-off-by: Matteo Suppo matteo.suppo@gmail.com

matteosuppo added some commits Mar 17, 2017

Add failing test for headers inside resource
See #915

Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
Avoid polluting the resource headers
AttributeDefinition.Merge changes in place the object. By merging the action headers into
the resource headers the headers ended up being available in other actions too

Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
Send the resource headers when generating tests
Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Mar 17, 2017

Thank you!

@raphael raphael merged commit b84239b into goadesign:v1 Mar 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment