Add an argument to CollectionOf() #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it possible to specify the collection identifier.
|
I don't know why travis was failed :( |
raphael
reviewed
May 19, 2017
design/apidsl/media_type.go
Outdated
| for _, p := range paramAndDSL { | ||
| param, ok = p.(string) | ||
| if !ok { | ||
| dslengine.ReportError("invalid CollectionOf argument, must be a string", p) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
design/apidsl/media_type_test.go
Outdated
| }) | ||
| }) | ||
|
|
||
| Context("defined with the collectio identifier", func() { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
design/apidsl/media_type.go
Outdated
| func CollectionOf(v interface{}, apidsl ...func()) *design.MediaTypeDefinition { | ||
| // | ||
| // CollectionOf(BottleMedia) // If the identifier of BottleMedia is "vnd.goa.bottle', | ||
| // // Content-Type will be "vnd.goa.bottle; type=collection". |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
design/apidsl/media_type.go
Outdated
| @@ -376,9 +376,17 @@ func Link(name string, view ...string) { | |||
| // CollectionOf creates a collection media type from its element media type. A collection media | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
design/apidsl/media_type.go
Outdated
| @@ -376,9 +376,17 @@ func Link(name string, view ...string) { | |||
| // CollectionOf creates a collection media type from its element media type. A collection media | |||
| // type represents the content of responses that return a collection of resources such as "list" | |||
| // actions. This function can be called from any place where a media type can be used. | |||
| // | |||
| // The resulting media type identifier is built from the element media type by appending the media | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
design/apidsl/media_type.go
Outdated
| // | ||
| // The collection identifier can be specified as second argument. | ||
| // | ||
| // CollectionOf(BottleMedia, "vnd.goa.bottles") // Content-Type will be "vnd.goa.bottles". |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I added a fixing commit! |
|
Would you mind backporting this to v1? Thank you! |
tchssk
added a commit
to tchssk/goa
that referenced
this pull request
May 21, 2017
* Add an argument to CollectionOf() It makes it possible to specify the collection identifier. * Fix documents and a test description
raphael
pushed a commit
that referenced
this pull request
May 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it possible to specify the collection identifier.