New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process resource without a parent first #1282

Merged
merged 2 commits into from Jun 28, 2017

Conversation

Projects
None yet
2 participants
@fixl
Copy link
Contributor

fixl commented Jun 26, 2017

Resources without a parent may be parents of other resources. For
deeper levels of nesting this is a problem.

E.g. Z -> Y -> X isn't sorted properly, but X needs to be processed first.

Stefan Fuchs
Process resource without a parent first
Resources without a parent may be parents of other resources. For
deeper levels of nesting this can be a problem.
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jun 26, 2017

Thanks for doing this! Could you please add a test that this fixes?

@fixl

This comment has been minimized.

Copy link
Contributor

fixl commented Jun 26, 2017

Added. Was a little trickier than I initially thought.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Jun 28, 2017

Looks great, thank you for doing this! Can you please backport the fix (cherry-pick) to the v1 branch?

@raphael raphael merged commit 05751d8 into goadesign:master Jun 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fixl added a commit to fixl/goa that referenced this pull request Jun 28, 2017

Process resource without a parent first (goadesign#1282)
* Process resource without a parent first

Resources without a parent may be parents of other resources. For
deeper levels of nesting this can be a problem.

* Iterate over every previous element to ensure no parent was missed

raphael added a commit that referenced this pull request Jun 28, 2017

Process resource without a parent first (#1282) (#1289)
* Process resource without a parent first

Resources without a parent may be parents of other resources. For
deeper levels of nesting this can be a problem.

* Iterate over every previous element to ensure no parent was missed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment